fix(release): drop Windows target, fix sha256sum portability#68
Merged
Conversation
- release.yml: remove windows-amd64 from matrix — code uses Linux/Unix-only syscalls (Stat_t, Lstat, unix.Kill, Setsid) that do not compile on Windows; add fail-fast: false so a single platform failure cannot cancel the others - install.sh: replace bare sha256sum with portable _sha256check() that falls back to 'shasum -a 256' on macOS where sha256sum is not available
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
syscall.Stat_t,unix.Kill,Setsid, etc.) that do not compile on Windows. Documented as unsupported in README.fail-fast: falseadded to matrix so a single platform failure cannot cancel the other builds.sha256sumportability —install.shnow uses a_sha256check()helper that falls back toshasum -a 256on macOS wheresha256sumis not available.Next step
After merge: delete the failed
v0.1.0tag and re-push it to trigger a clean release.